Skip to content

feat: JSON Schema grammar enhancements #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 1, 2024
Merged

feat: JSON Schema grammar enhancements #388

merged 13 commits into from
Dec 1, 2024

Conversation

@giladgd
Copy link
Member

@giladgd giladgd commented Nov 27, 2024 •
edited
Loading

Description of change

  • feat(JSON Schema grammar): prefixItems, minItems, maxItems support
  • feat(JSON Schema grammar): improve inferred types
  • feat(JSON Schema grammar): object additionalProperties, minProperties, maxProperties
  • feat(JSON Schema grammar): string minLength, maxLength, format
  • feat(function calling): params description support
  • feat(function calling): document JSON Schema type properties on Functionary chat function types
  • docs: how to reduce hallucinations when using JSON schema grammar
  • fix: bugs
  • chore: update dependencies

Resolves #384

Added a section in the documentation about reducing hallucinations when using JSON Schema grammar.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd self-assigned this Nov 27, 2024
@giladgd giladgd force-pushed the gilad/jsonSchemaImprovements branch from 3174065 to 938c1eb Compare November 28, 2024 00:19
@giladgd giladgd marked this pull request as ready for review December 1, 2024 22:27
@giladgd giladgd requested a review from ido-pluto December 1, 2024 22:28
ido-pluto
ido-pluto approved these changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd merged commit 4d387de into master Dec 1, 2024
15 checks passed
@giladgd giladgd deleted the gilad/jsonSchemaImprovements branch December 1, 2024 23:36
@github-actions
Copy link

github-actions bot commented Dec 2, 2024

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@0xdevalias 0xdevalias mentioned this pull request Feb 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ido-pluto ido-pluto ido-pluto approved these changes

Assignees

@giladgd giladgd

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Supporting minItems and others in LlamaJsonSchemaGrammar

3 participants

@giladgd @ido-pluto